New {{ repo_arch }} variable usable instead of $basearch #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
praiskup
force-pushed
the
mageia-basearch
branch
from
8e9863e
to
27d5e11
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Ok, the basearch seems to be useless indeed. I think the current version of the patch could help, so we keep using native architecture for the bootstrap chroot, and emulated for target chroot. Even though... I don't get why The very same on-host command is used: - /usr/bin/dnf-3 --installroot /var/lib/mock/mageia-8-armv7hl-bootstrap/root/ --releasever 8 --setopt=deltarpm=False --setopt=allow_vendor_change=yes --allowerasing --disableplugin=local --disableplugin=spacewalk --disableplugin=versionlock install python3-dnf python3-dnf-plugins-core --setopt=tsflags=nocontexts
+ /usr/bin/dnf-3 --installroot /var/lib/mock/mageia-8-x86_64-bootstrap/root/ --releasever 8 --setopt=deltarpm=False --setopt=allow_vendor_change=yes --allowerasing --disableplugin=local --disableplugin=spacewalk --disableplugin=versionlock install python3-dnf python3-dnf-plugins-core --setopt=tsflags=nocontextsThe very same configuration is used, except for user_agent: |
|
ping @pterjan |
|
Mageia 8 is EOL anyway, so I'm a bit less concerned about it, but does this problem come up in Mageia 9? |
|
Mageia 9 behaves the same: |
|
Is the bootstrap chroot supposed to use the native arch? That seems broken. |
|
That is what we do for Fedora, so yes. Is there a reason why this shouldn't work for Mageia? |
|
Hm, I think this happens because we set |
praiskup
added a commit
to praiskup/mock
that referenced
this pull request
Feb 9, 2024
This option is used for the cases when $basearch DNF native variable doesn't work as expected in URLs. On top of this, Mock uses `repo_arch` for `man 2 personality` decisions for the bootstrap chroot installation which is supposed to be native. Closes: rpm-software-management#1317 Fixes: rpm-software-management#1304
praiskup
force-pushed
the
mageia-basearch
branch
from
27d5e11
to
e4cc2e5
Compare
praiskup
added a commit
to praiskup/mock
that referenced
this pull request
Feb 9, 2024
This option is used for the cases when $basearch DNF native variable doesn't work as expected in URLs. On top of this, Mock uses `repo_arch` for `man 2 personality` decisions for the bootstrap chroot installation (supposed to be native). Closes: rpm-software-management#1317 Fixes: rpm-software-management#1304
praiskup
force-pushed
the
mageia-basearch
branch
from
e4cc2e5
to
3d2c93f
Compare
praiskup
added a commit
to praiskup/mock
that referenced
this pull request
Feb 9, 2024
This option is used for the cases when $basearch DNF-native variable doesn't work as expected in URLs. On top of this ^^^, Mock newly uses `repo_arch` for the `man 2 personality` decisions during the bootstrap chroot initialization (bootstrap is expected to be native). Closes: rpm-software-management#1317 Fixes: rpm-software-management#1304
praiskup
force-pushed
the
mageia-basearch
branch
from
3d2c93f
to
5aa6f35
Compare
praiskup
added a commit
to praiskup/mock
that referenced
this pull request
Feb 9, 2024
This option is used for the cases when $basearch DNF-native variable doesn't work as expected in URLs. On top of this ^^^, Mock newly uses `repo_arch` for the `man 2 personality` decisions during the bootstrap chroot initialization (bootstrap is expected to be native). Closes: rpm-software-management#1317 Fixes: rpm-software-management#1304
praiskup
force-pushed
the
mageia-basearch
branch
from
5aa6f35
to
a597bf9
Compare
|
Can anyone test/check if this change is acceptable? Unfortunately, this is not just "config-only" patch. |
praiskup
changed the title
praiskup
added a commit
to praiskup/mock
that referenced
this pull request
Feb 9, 2024
This option is used for the cases when $basearch DNF-native variable doesn't work as expected in URLs. On top of this ^^^, Mock newly uses `repo_arch` for the `man 2 personality` decisions during the bootstrap chroot initialization (bootstrap is expected to be native). Closes: rpm-software-management#1317 Fixes: rpm-software-management#1304
praiskup
force-pushed
the
mageia-basearch
branch
from
a597bf9
to
ae7586d
Compare
I have tested the changes and everything seems to be working at least with Mageia Cauldron x86_64 host. I tried to build pkgs for armvh7l, aarch64, i586, and x86_64. |
praiskup
added a commit
to praiskup/mock
that referenced
this pull request
Feb 9, 2024
This option is used for the cases when $basearch DNF-native variable doesn't work as expected in URLs. On top of this ^^^, Mock newly uses `repo_arch` for the `man 2 personality` decisions during the bootstrap chroot initialization (bootstrap is expected to be native). Closes: rpm-software-management#1317 Fixes: rpm-software-management#1304
praiskup
force-pushed
the
mageia-basearch
branch
from
ae7586d
to
67850cd
Compare
praiskup
added a commit
to praiskup/mock
that referenced
this pull request
Feb 9, 2024
This option is used for the cases when $basearch DNF-native variable doesn't work as expected in URLs. On top of this ^^^, Mock newly uses `repo_arch` for the `man 2 personality` decisions during the bootstrap chroot initialization (bootstrap is expected to be native). Closes: rpm-software-management#1317 Fixes: rpm-software-management#1304
praiskup
force-pushed
the
mageia-basearch
branch
from
67850cd
to
55ed862
Compare
|
Ok, thank you for checking. The last versions got fixes for Fedora builds (bootstrap image + multilib builds). |
|
From the tests: But we do not test --forcearch builds. These were tested manually by @wally-mageia |
This option is used for the cases when $basearch DNF-native variable doesn't work as expected in URLs. Mock now also uses the `repo_arch` values for the `man 2 personality` decisions during the bootstrap chroot initialization, as bootstrap is is almost always expected to be "host-native". Closes: rpm-software-management#1317 Fixes: rpm-software-management#1304
praiskup
force-pushed
the
mageia-basearch
branch
from
55ed862
to
d94aa10
Compare
Conan-Kudo
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the native bootstrap preparation for cross-arch (emulated) builds.