Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mock: fix dynamic buildrequires unnecesarry loop #482

Closed
wants to merge 1 commit into from
Closed

mock: fix dynamic buildrequires unnecesarry loop #482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions mock/py/mockbuild/backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,6 +708,7 @@ def get_command(mode):
except Error as e:
if e.resultcode != 11:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please document the fact that we accept exit_status 0 and exit_status 11, and why.

raise e
finally:
max_loops -= 1
self.buildroot.root_log.info("Dynamic buildrequires detected")
self.buildroot.root_log.info("Going to install missing buildrequires")
Expand Down