mock: use 'private' mount option, not 'rprivate' #536
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praiskup
force-pushed
the
private-not-rprivate
branch
from
5186072
to
04ce240
Compare
The 'mount --rbind -o rprivate' on EL7 does weird things; it looks like it actually reverses the '--rbind' option and does only '--bind'. Using just 'private' seems to do the same (good) thing on both EL7 and modern Fedora. This fixes local baseurl=file:// repositories with bootstrap, and yum_chache plugin on EL7. Fixes: rpm-software-management#381
praiskup
force-pushed
the
private-not-rprivate
branch
from
04ce240
to
b5e8d80
Compare
|
I believe this was introduced as PR to make this work under Fedora Toolbox. Check discussion in that PR. |
|
Hmm, I don't think we discussed |
|
I think that we discussed |
|
Hm, it actually looks like we never tested bootstrap chroot with toolbox. |
|
Ok, I tested: |
praiskup
added a commit
that referenced
this pull request
Mar 20, 2020
The 'mount --rbind -o rprivate' on EL7 does not work as we expected [1]; it looks like it actually reverses the '--rbind' option and does only '--bind' (filled rhbz#1815534). Using just 'private' seems to do the same (good) thing on both EL7 and modern Fedora. This fixes local baseurl=file:// repositories with bootstrap, and yum_chache plugin on EL7. Fixes: #381, #536 Relates: https://bugzilla.redhat.com/show_bug.cgi?id=1815534
|
Merged as 34fe0d5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'mount --rbind -o rprivate' on EL7 does weird things; it looks like
it actually reverses the '--rbind' option and does only '--bind'. Using
just 'private' seems to do the same (good) thing on both EL7 and modern
Fedora.
This fixes yum_chache plugin on EL7.