compress_logs: compress also after repo failures #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs fix, this doesn't compress logs when there's no exception. |
praiskup
force-pushed
the
always-compress-logs
branch
from
bc612eb
to
affd60e
Compare
Before, errors like
Errors during downloading metadata for repository 'local'
Ended up with non-compressed logs in resultdir.
We can not easily move the 'postbuild' hook call as others already
depend on that - so I'm proposing a new hook for log processing.
TODO: Fix for --postinstall is still needed.
Original report:
https://pagure.io/copr/copr/issue/1648
praiskup
force-pushed
the
always-compress-logs
branch
from
affd60e
to
b53762f
Compare
|
Meh, not awesome, not 100% complete - but simple change enough. PTAL |
xsuchy
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, errors like
Errors during downloading metadata for repository 'local'
Ended up with non-compressed logs in resultdir.
We can not easily move the 'postbuild' hook call as others already
depend on that - so I'm proposing a new hook for log processing.
Original report:
https://pagure.io/copr/copr/issue/1648