Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen the python3-libmodulemd dependency to just libmodulemd #16

Merged
merged 1 commit into from
Nov 2, 2020

Conversation

FrostyX
Copy link
Member

@FrostyX FrostyX commented Nov 1, 2020

There is no python3-libmodulemd package for EPEL8, it is
a part of the libmodulemd package. For Fedora, we have both
options. So let's not if-else the spec and just install libmodulemd
everywhere and presume, that the python library will be available.

@sgallagher
Copy link
Contributor

That’s incorrect and will cause problems. You need to pull in the appropriate pythonX-libmodulemd package or you will not have the python overrides allowing pythonic interaction with the XMD and EOL features.

@sgallagher
Copy link
Contributor

@FrostyX
Copy link
Member Author

FrostyX commented Nov 1, 2020

Hello @sgallagher,
thank you for the review and the RHBZ link.

That’s incorrect and will cause problems. You need to pull in the appropriate pythonX-libmodulemd package or you will not have the python overrides allowing pythonic interaction with the XMD and EOL features.

Not arguing here, I wasn't aware of this. However, there doesn't seem to be any XMD or EOL related code

[jkadlcik@unknown modulemd-tools]$ git grep -i xmd
[jkadlcik@unknown modulemd-tools]$ git grep -i eol
[jkadlcik@unknown modulemd-tools]$

and I tested the package and all the tools in centos:8 and fedora:33 containers and they work just fine (there is a missing dependency on createrepo_c which is a minor issue).

Should we wait till RHEL 8.3 (per RHBZ 1860401) or can we go with this incorrect dependency and then switch it back to the python3-libmodulemd once it is available?

@FrostyX
Copy link
Member Author

FrostyX commented Nov 1, 2020

Just for the record, here you can find a modulemd-tools package built from this PR:
https://copr.fedorainfracloud.org/coprs/frostyx/modulemd-tools/build/1737168/

@sgallagher
Copy link
Contributor

My main concern is that if we add any other overrides to libmodulemd, you may not get them if you aren’t pulling in the correct sub-package.

That said, if you are going to temporarily switch, please make sure to open a ticket to change it back.

There is no `python3-libmodulemd` package for EPEL8, it is
a part of the `libmodulemd` package. For Fedora, we have both
options. So let's not if-else the spec and just install `libmodulemd`
everywhere and presume, that the python library will be available.

This is meant to be only a temporary solution until
`python3-libmodulemd` is available even for EPEL8, please see
https://bugzilla.redhat.com/show_bug.cgi?id=1860401

By depending on `libmodulemd` instead of `python3-libmodulemd` we
won't get any overrides to `libmodulemd`, which may cause
problems. Please see the discussion in PR rpm-software-management#16.
@FrostyX
Copy link
Member Author

FrostyX commented Nov 2, 2020

Okay, thank you @sgallagher!

I updated the commit message so it says that this is supposed to be a temporary solution and also create #17 so we don't forget to switch back to the correct dependency once it is available.

Until then, let's try to go with this change, so we can start experimenting with this package on EPEL8.

@FrostyX FrostyX merged commit 7edcd63 into rpm-software-management:master Nov 2, 2020
@plopresti
Copy link

Just for the record, here you can find a modulemd-tools package built from this PR:
https://copr.fedorainfracloud.org/coprs/frostyx/modulemd-tools/build/1737168/

Any hope of seeing these packages in EPEL?

@FrostyX
Copy link
Member Author

FrostyX commented Nov 11, 2020

Hello @plopresti,
there is currently a bodhi update for EPEL8

https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-7e95555077

so, within a week or 3 karma points :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants