-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loosen the python3-libmodulemd dependency to just libmodulemd #16
Conversation
That’s incorrect and will cause problems. You need to pull in the appropriate pythonX-libmodulemd package or you will not have the python overrides allowing pythonic interaction with the XMD and EOL features. |
Hello @sgallagher,
Not arguing here, I wasn't aware of this. However, there doesn't seem to be any XMD or EOL related code
and I tested the package and all the tools in Should we wait till RHEL 8.3 (per RHBZ 1860401) or can we go with this incorrect dependency and then switch it back to the |
Just for the record, here you can find a |
My main concern is that if we add any other overrides to libmodulemd, you may not get them if you aren’t pulling in the correct sub-package. That said, if you are going to temporarily switch, please make sure to open a ticket to change it back. |
There is no `python3-libmodulemd` package for EPEL8, it is a part of the `libmodulemd` package. For Fedora, we have both options. So let's not if-else the spec and just install `libmodulemd` everywhere and presume, that the python library will be available. This is meant to be only a temporary solution until `python3-libmodulemd` is available even for EPEL8, please see https://bugzilla.redhat.com/show_bug.cgi?id=1860401 By depending on `libmodulemd` instead of `python3-libmodulemd` we won't get any overrides to `libmodulemd`, which may cause problems. Please see the discussion in PR rpm-software-management#16.
Okay, thank you @sgallagher! I updated the commit message so it says that this is supposed to be a temporary solution and also create #17 so we don't forget to switch back to the correct dependency once it is available. Until then, let's try to go with this change, so we can start experimenting with this package on EPEL8. |
Any hope of seeing these packages in EPEL? |
Hello @plopresti, https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-7e95555077 so, within a week or 3 karma points :-) |
There is no
python3-libmodulemd
package for EPEL8, it isa part of the
libmodulemd
package. For Fedora, we have bothoptions. So let's not if-else the spec and just install
libmodulemd
everywhere and presume, that the python library will be available.