Skip to content

Commit

Permalink
Preparing for rpm 4.20.0-alpha2
Browse files Browse the repository at this point in the history 
Commit 5ce5604 added a new public API
function so bump the minor lib version, "pin" the new test hashes also.
  • Loading branch information
@dmnks
dmnks committed May 17, 2024
1 parent 3108a23 commit 3b3c948
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
4 changes: 2 additions & 2 deletions CMakeLists.txt
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
cmake_minimum_required(VERSION 3.18)

project(rpm
VERSION 4.19.90
VERSION 4.19.91
DESCRIPTION "The RPM Package Manager"
HOMEPAGE_URL "http://rpm.org"
LANGUAGES C
Expand Down Expand Up @@ -52,7 +52,7 @@ set(RPM_VENDOR "vendor" CACHE STRING "rpm vendor string")
# - incrementing a more significant version segment resets changes to
# any less significant segments
set(RPM_SOVERSION 10)
set(RPM_LIBVERSION ${RPM_SOVERSION}.1.0)
set(RPM_LIBVERSION ${RPM_SOVERSION}.2.0)

This comment has been minimized.

Sign in to view

Copy link
@pmatilai

pmatilai Jun 24, 2024 •
edited
Loading

Member

I haven't traditionally updated the library versions between pre-release stages even if and when the API changed a bit, and the code of course always changes. Basically I interpreted the "Update the version information only immediately before a public release of your software" in libtool version updating instructions per final release, so the info is only updated in the alpha (or so) release and not after that, basically because these pre-release versions are not something under longterm support so "we don't care". Of course there are several arguments to the contrary, certainly pre-releases are public releases too, updating for them is more technically correct and there aren't so many of them to considerably inflate the numbers. Just mentioning this as a FYI/FWIW thing, in case you ever run into this in older releases and wonder 😅

set(CMAKE_C_STANDARD 99)
set(CMAKE_C_STANDARD_REQUIRED ON)
Expand Down
8 changes: 4 additions & 4 deletions tests/pinned/rpmlibver.txt
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
librpm.so.10.1.0
librpmbuild.so.10.1.0
librpmio.so.10.1.0
librpmsign.so.10.1.0
librpm.so.10.2.0
librpmbuild.so.10.2.0
librpmio.so.10.2.0
librpmsign.so.10.2.0
6 changes: 3 additions & 3 deletions tests/pinned/rpmsigdig.txt
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
SHA256HEADER: 8ab715bef152a18bef62df29805b9d1b8f2c5d92955a1a7fa2491967cc17c035
SHA1HEADER: 7a8ad9bdb9b0910fa54724f7bdac8ac49d992d2f
SIGMD5: 87da99d1993240e2d698f5b3dbcbd44c
SHA256HEADER: e84020faa75049b55b99e4f366fcde85650db04d51058f4c485cb84ead4926e6
SHA1HEADER: e7ed8eda7fd51e2a8d45d2aeda4b0ee94769340b
SIGMD5: ce2d836ce7c22a1ef4b1aec3b08d26be
PAYLOADDIGEST: 116ce41ebb72f1877cda3d7dedaf5b78770e202d6389ade4e415d78548d703a8
PAYLOADDIGESTALT: 116ce41ebb72f1877cda3d7dedaf5b78770e202d6389ade4e415d78548d703a8
/build/RPMS/4/noarch/attrtest-1.0-1.noarch.rpm:
Expand Down

0 comments on commit 3b3c948

Please sign in to comment.