Skip to content

Commit

Permalink
Prevent patch asking questions during build
Browse files Browse the repository at this point in the history
Builds should always run unattended and never require user interactions.
We also don't want unser input to affect the result. Without any options
patch will ask for files to patch or whether it should reverse pachtes if
they could be applied then.

As -t aka --batch does reverse patches and skips patches with wrong version
for the Prereq: line it is not suited for rpmbuild. We rather want the
build to fail than silently drop (possibly security relevant) patches.

We would prefer patch to error out when ever the patch looks not quite matching
but -f aka --force is the option available closest to that.

See man patch for details

Resolves: #978
  • Loading branch information
ffesti committed Jan 25, 2021
1 parent b3e30d9 commit 3ebd622
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion macros.in
Expand Up @@ -389,7 +389,7 @@ package or when debugging this package.\

# Default patch flags
#%_default_patch_flags -s
%_default_patch_flags --no-backup-if-mismatch
%_default_patch_flags --no-backup-if-mismatch -f

#==============================================================================
# ---- Build configuration macros.
Expand Down

0 comments on commit 3ebd622

Please sign in to comment.