Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpm2archive segfaults if URL is given #1091

Closed
ignatenkobrain opened this issue Feb 29, 2020 · 0 comments · Fixed by #1510
Closed

rpm2archive segfaults if URL is given #1091

ignatenkobrain opened this issue Feb 29, 2020 · 0 comments · Fixed by #1510
Assignees
@ffesti
Labels
bug

Comments

@ignatenkobrain
Copy link
Contributor 

           PID: 198189 (rpm2archive)
           UID: 1000 (brain)
           GID: 1000 (brain)
        Signal: 11 (SEGV)
     Timestamp: Sat 2020-02-29 13:35:39 CET (1min 2s ago)
  Command Line: rpm2archive https://jistone.fedorapeople.org/review//rust-cargo-platform-0.1.0-1.fc33.src.rpm
    Executable: /usr/bin/rpm2archive
 Control Group: /user.slice/user-1000.slice/user@1000.service/vte-spawn-f7e2e0b4-7f3c-432f-a83f-04b1f64da31c.scope
          Unit: user@1000.service
     User Unit: vte-spawn-f7e2e0b4-7f3c-432f-a83f-04b1f64da31c.scope
         Slice: user-1000.slice
     Owner UID: 1000 (brain)
       Boot ID: 5ed3cba3c4f04ce3bc4e08acb4f8194d
    Machine ID: 6b8a1e0b45614719a73efb4392cc0ef5
      Hostname: konsky-kokot.localdomain
       Storage: /var/lib/systemd/coredump/core.rpm2archive.1000.5ed3cba3c4f04ce3bc4e08acb4f8194d.198189.1582979739000000000000.lz4
       Message: Process 198189 (rpm2archive) of user 1000 dumped core.
                
                Stack trace of thread 198189:
                #0  0x00007f5dbbc7dc24 __archive_write_filter (libarchive.so.13 + 0x6ec24)
                #1  0x00007f5dbbc7dcbc __archive_write_nulls (libarchive.so.13 + 0x6ecbc)
                #2  0x00007f5dbbc7d766 _archive_write_close (libarchive.so.13 + 0x6e766)
                #3  0x0000556f52a50d64 main (rpm2archive + 0x2d64)
                #4  0x00007f5dbba6c052 __libc_start_main (libc.so.6 + 0x27052)
                #5  0x0000556f52a50fbe _start (rpm2archive + 0x2fbe)

I did not install debugdata, but I think it is probably not needed with such simple reproducer :)
@ffesti ffesti added this to High priority in Ticket Review (Outdated) Mar 3, 2020
@ffesti ffesti moved this from High priority to Low priority in Ticket Review (Outdated) Mar 3, 2020
@ffesti ffesti moved this from Yes to Go in Ticket Review (Outdated) Mar 3, 2020
@ffesti ffesti added this to the 4.16.0 milestone Mar 19, 2020
@pmatilai pmatilai removed this from the 4.16.0 milestone Dec 2, 2020
@ffesti ffesti self-assigned this Jan 15, 2021
ffesti added a commit to ffesti/rpm that referenced this issue Jan 18, 2021
@ffesti
rpm2archive: Add more error handling
205d59f 
Cleanly error out if file can't be written instead of segfaulting

Resolves: rpm-software-management#1091
ffesti added a commit to ffesti/rpm that referenced this issue Jan 18, 2021
@ffesti
rpm2archive: Use last part of URL as file name
0931d92 
when getting a file from an URL. This prevents trying to write the file
at the location of the full URL which fails most of the time.

Related: rpm-software-management#1091
@ffesti ffesti mentioned this issue Jan 18, 2021
Merged
Ticket Review (Outdated) automation moved this from Go to Closed Jan 19, 2021
pmatilai pushed a commit that referenced this issue Jan 19, 2021
@ffesti @pmatilai
rpm2archive: Add more error handling
f163425 
Cleanly error out if file can't be written instead of segfaulting

Resolves: #1091
pmatilai pushed a commit that referenced this issue Jan 19, 2021
@ffesti @pmatilai
rpm2archive: Use last part of URL as file name
98565f9 
when getting a file from an URL. This prevents trying to write the file
at the location of the full URL which fails most of the time.

Related: #1091
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ffesti ffesti

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rpm2archive: Better error handling and better handling for URLs ffesti/rpm
3 participants
@ffesti @ignatenkobrain @pmatilai