%1 in parametric generator contains doubled %{buildroot} #1162
Comments
ignatenkobrain
added a commit
to ignatenkobrain/rpm
that referenced
this issue
Apr 5, 2020
'fn' already contains full path to a file, so no need to prepend it once
more. This is actually breaking things.
Before:
D: Calling %{__pythonname_provides %{?__pythonname_provides_opts}}() on /home/brain/rpmbuild/BUILDROOT/hello-1-1.fc33.x86_64//home/brain/rpmbuild/BUILDROOT/hello-1-1.fc33.x86_64/usr/share/applications/org.gnome.Terminal.desktop
After:
D: Calling %{__pythonname_provides %{?__pythonname_provides_opts}}() on /home/brain/rpmbuild/BUILDROOT/hello-1-1.fc33.x86_64/usr/share/applications/org.gnome.Terminal.desktop
Fixes: rpm-software-management#1162
Signed-off-by: Igor Raits <i.gnatenko.brain@gmail.com>
|
Fixed as one of commits in #1163. |
pmatilai
pushed a commit
to pmatilai/rpm
that referenced
this issue
Apr 6, 2020
'fn' already contains full path to a file, so no need to prepend it once
more. This is actually breaking things.
Before:
D: Calling %{__pythonname_provides %{?__pythonname_provides_opts}}() on /home/brain/rpmbuild/BUILDROOT/hello-1-1.fc33.x86_64//home/brain/rpmbuild/BUILDROOT/hello-1-1.fc33.x86_64/usr/share/applications/org.gnome.Terminal.desktop
After:
D: Calling %{__pythonname_provides %{?__pythonname_provides_opts}}() on /home/brain/rpmbuild/BUILDROOT/hello-1-1.fc33.x86_64/usr/share/applications/org.gnome.Terminal.desktop
Fixes: rpm-software-management#1162
Signed-off-by: Igor Raits <i.gnatenko.brain@gmail.com>
pmatilai
pushed a commit
that referenced
this issue
Apr 6, 2020
'fn' already contains full path to a file, so no need to prepend it once
more. This is actually breaking things.
Before:
D: Calling %{__pythonname_provides %{?__pythonname_provides_opts}}() on /home/brain/rpmbuild/BUILDROOT/hello-1-1.fc33.x86_64//home/brain/rpmbuild/BUILDROOT/hello-1-1.fc33.x86_64/usr/share/applications/org.gnome.Terminal.desktop
After:
D: Calling %{__pythonname_provides %{?__pythonname_provides_opts}}() on /home/brain/rpmbuild/BUILDROOT/hello-1-1.fc33.x86_64/usr/share/applications/org.gnome.Terminal.desktop
Fixes: #1162
Signed-off-by: Igor Raits <i.gnatenko.brain@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I was trying to port desktop generator to a parametric macro, but hit the problem that
rpm.expand("%1")results into/home/brain/rpmbuild/BUILDROOT/hello-1-1.fc33.x86_64//home/brain/rpmbuild/BUILDROOT/hello-1-1.fc33.x86_64/usr/share/applications/org.gnome.Terminal.desktop.As you can see, the BUILDROOT part is twice there.
This seems like a very trivial fix. I'll send PR.
The text was updated successfully, but these errors were encountered: