Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for Source URLs lacking tarball name #238

Closed
chorsley opened this issue Jun 21, 2017 · 0 comments
Closed

Improve error message for Source URLs lacking tarball name #238

chorsley opened this issue Jun 21, 2017 · 0 comments
Labels

Comments

@chorsley
Copy link

I was using rpmbuild to create Python RPMs based on a local tarball. I would receive this somewhat cryptic error:

error: File /home/makerpm/rpmbuild/SOURCES: Is a directory

After digging through the rpmbuild code for hints, it turned out that where py2pack (which I used for generating spec files) produced a spec file header of:

Source: https://files.pythonhosted.org/packages/source/m/mixbox/

I needed:

Source: https://files.pythonhosted.org/packages/source/m/mixbox/mixbox-%{version}.tar.gz

It was not obvious to me that the name of the tarball in fact needed to be in the external URL when I was building everything locally. I'd like to suggest a more explicit error if the version / tarball name cannot be extracted from the Source field.

@ffesti ffesti closed this as completed in 23d37ea Mar 13, 2018
pmatilai pushed a commit that referenced this issue Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants