Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate away from SemaphoreCI Classic #2569

Closed
pmatilai opened this issue Jul 7, 2023 · 7 comments
Closed

Migrate away from SemaphoreCI Classic #2569

pmatilai opened this issue Jul 7, 2023 · 7 comments
Assignees
Labels
test Testsuite-related
Milestone

Comments

@pmatilai
Copy link
Member

pmatilai commented Jul 7, 2023

From https://semaphoreci.com/blog/semaphore-classic-deprecation:

However, we are excited to announce that Semaphore Classic will be discontinued by September 30, 2023.

It's an interesting way to put it. Okay, maybe their engineers are excited to be finally rid of a legacy platform that's pain to support, I can totally symphatize with that. At any rate, we need to move our business elsewhere before that.

Reading further into the announcement, they'll be introducing "brownouts" to the service starting from beginning of September, so we'll want to be out by then. So, we have a deadline here: migrate away from SemaphoreCI Classic before September 1st.

@pmatilai pmatilai added the test Testsuite-related label Jul 7, 2023
@nwalfield
Copy link
Contributor

For rpm-sequoia, I'm running the rpm test suite from GitHub's Actions. The only issue is that it runs on Ubuntu and not Fedora or some other rpm-base distribution. As I understand it, GitHub has no plans to add such an image. Perhaps GitHub actions have a way to bring your own image; I didn't investigate.

@wiktor-k
Copy link

wiktor-k commented Jul 7, 2023

Hi,

I think using Docker directly would solve this problem (as then you can use fedora as a base image).

There are at least two approaches:

It seems you already have a Dockerfile: https://github.com/rpm-software-management/rpm/blob/master/ci/Dockerfile

Do you just need to run that on GitHub actions? If so I think I could lend a hand :)

@dralley
Copy link
Contributor

dralley commented Jul 18, 2023

You can use Fedora as a base image with Github Actions too - of course the VM will still be Ubuntu, but all of the commands can run inside of a container image of your choosing.

https://docs.github.com/en/actions/using-jobs/running-jobs-in-a-container#defining-the-container-image

See for example: https://github.com/rpm-software-management/createrepo_c/blob/master/.github/workflows/ci-python.yml#L8-L16

@dmnks
Copy link
Contributor

dmnks commented Aug 3, 2023

Thanks everyone for the input! We went with GH Actions in the end (#2598).

@dmnks
Copy link
Contributor

dmnks commented Aug 3, 2023

I've also changed the required check to be the newly added GH workflow instead of SemaphoreCI.

This has resulted in all the open PRs to be stuck on "Waiting for status to be reported", due to those branches not being rebased on top of master and thus missing a workflow file. That means the respective PR authors will need to rebase their branches themselves, however that's what we actually want, due to the recent test-suite rework, anyway.

@dmnks
Copy link
Contributor

dmnks commented Aug 3, 2023

One more note: I'll keep the SemaphoreCI check in place for a little while, just to have something to compare to in case of any unexpected failures in the new GH workflow.

dmnks pushed a commit to dmnks/rpm that referenced this issue Sep 1, 2023
dmnks pushed a commit to dmnks/rpm that referenced this issue Sep 4, 2023
dmnks pushed a commit that referenced this issue Sep 4, 2023
@pmatilai pmatilai added this to the 4.19.0-rc milestone Sep 12, 2023
@pmatilai
Copy link
Member Author

For the record, we pulled the plug on SemaphoreCI builds on Sep 1st.

dmnks pushed a commit to dmnks/rpm that referenced this issue Nov 8, 2023
dmnks pushed a commit to dmnks/rpm that referenced this issue Nov 13, 2023
dmnks pushed a commit that referenced this issue Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Testsuite-related
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants