rpmspec default output unexpected

[bracketttc]

In prior versions of rpmspec (4.17 and earlier), rpmspec -q output using a format apparently %{nevra}\n.
In the current version (and in the version of 4.18 in Fedora 35), the output looks like %{nevr}.src\n.
If you specify --queryformat '%{nevra}\n', you get the expected output.

[bracketttc]

Changed in 82dafa3.

Current source of archsuffixTag():

static int archsuffixTag(Header h, rpmtd td, headerGetFlags hgflags)
{
    const char *a = NULL;
    char * val;


    if (headerIsSource(h)) {
        if (headerIsEntry(h, RPMTAG_NOSOURCE) ||
            headerIsEntry(h, RPMTAG_NOPATCH))
            a = "nosrc";
        else
            a = "src";
    } else {
        a = headerGetString(h, RPMTAG_ARCH);
    }


    if (a)
        val = rstrscat(NULL, ".", a, NULL);
    else
        val = xstrdup("");


    td->type = RPM_STRING_TYPE;
    td->data = val;
    td->count = 1;
    td->flags = RPMTD_ALLOCED;


    return 1;
}

So, I'm guessing that when rpmspec calls this, the Header they're passing in thinks it's a source RPM header which makes a sort of sense programmatically, but it doesn't make sense to me for --rpms, and --builtrpms (which are synonymous with the default query).

[pmatilai]

That'd be a bug, or rather, a regression. .src is only a valid arch for a source rpm.

So 'rpmspec -q' can never legitimately return an .src arch, but 'rpmspec -q --srpm' must return either src or nosrc.

Thanks for reporting!