Explicitly mention that the rpmio/ sub dir is under LGPL #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pmatilai Why would signing (also split out from lib) be desirable as GPL verses LGPL? |
|
Basically I think that's in line with the original split of letting everybody read rpms but only open source projects are allowed to write (to) them. Or call it a general sense of hygiene wrt binary blobs if you like 😄 |
|
Hmm, makes sense. What about importing GPG keys and keyring management? That's not in sign, is it? |
|
No, signing is just, well, signing. Keyring stuff is in librpm/librpmio. |
As the code in the rpmio sub directory was split out of the lib sub dir it is already under LGPL as "code derived from" "the source code in the lib subdirectory" according to the license. But not having the sub directory mentioned in the license confuses users and contributers. The original release tarballs in http://ftp.rpm.org/releases/historical/ show the license was changed into the existing dual one between rpm 2.4.3 and 2.4.4, and that no rpmio/ directory exists at that time. Our git repo disagrees with the time of rpmio/ split due to some conversion artifacts (cvs to mercury to git), as it shows rpmio/ directory existing from the first commit, but this was not actually the case. The license stating that the dual license is there to allow linking with librpm from non-GPL code supports this interpretation as librpmio is required in order to use librpm even if it is a separate library nowadays. So this change does not change the license of any code but only clearifies the current situation. Resolves: rpm-software-management#516
|
Adjusted commit message to include more history and reasoning. |
|
And we have a winner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the code in the rpmio sub directory was split out of the lib sub dir
it is already under LGPL as "code derived from" "the source code in the
lib subdirectory" according to the license. But not having the sub directory
mentioned in the license confuses users and contributers.
So this change does not change the license of any code but only clearifies the
current situation.
Resolves: #516