Remove --sign from rpmbuild #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conan-Kudo
approved these changes
Jan 30, 2020
|
Hmm, can we exit with an error code there, to avoid any scripts etc thinking all was fine? |
|
I tried that but didn't get it to work. I'd also like to swallow the other cli arguments. Looks like the command is executed without a shell so what can be done easily is limited. |
|
How about this instead:
...which gives you both error on stderr, and a non-zero exit code: |
When splitting rpmsign from rpmbuild this command line parameter was kept as an popt alias. But this limits what other parameter can be passed to the rpmsign command in a difficult to understand way. In the end everyone is better off using the rpmsign command directly. Issue a error message stating the parameter is no longer supported and exit rpmbuild. Resolves: rpm-software-management#153
|
Yup, pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When splitting rpmsign from rpmbuild this command line parameter was kept
as an popt alias. But this limits what other parameter can be passed to
the rpmsign command in a difficult to understand way. In the end everyone
is better off using the rpmsign command directly.
Issue a error message stating the parameter is no longer supported
Resolves: #153