Support file classification by MIME type #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased to fix conflict. |
Conan-Kudo
approved these changes
Mar 5, 2020
In addition to "magic" strings, support classifying files by matches on their MIME types which are far more predictable than the notoriously volatile magic strings which are intended for human consumption. This adds an optional %__foo_mime and %__foo_exclude_mime patterns to file attributes. If the mime-variant is present, magic is ignored if present (with a warning). The testcase is a fine example of how the grass not necessarily being any greener on the other side: the actual output is far more predictable, but the actual classification is not. Our "script" with an arbitrary unknown interpreter is considered text/plain by libmagic. Fixes: rpm-software-management#1097
|
Rebased + check for non-existent %ghosts added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to "magic" strings, support classifying files by matches
on their MIME types which are far more predictable than the notoriously
volatile magic strings which are intended for human consumption.
This adds an optional %__foo_mime and %__foo_exclude_mime patterns
to file attributes. If the mime-variant is present, magic is ignored
if present (with a warning).
The testcase is a fine example of how the grass not necessarily being
any greener on the other side: the actual output is far more predictable,
but the actual classification is not. Our "script" with an arbitrary
unknown interpreter is considered text/plain by libmagic.
Fixes: #1097