Flush 1998 vintage dirent.h and fcntl.h compatibility mess from system.h #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added a missed dirent.h in fts.c (now there's another pile of ... to clean up) |
pmatilai
changed the title
dirent.h and struct dirent are actually standard on this millenium, the only thing that isn't is d_type member for which we have and retain a specific test in configure.ac. Include <dirent.h> where needed, relatively few places do which makes it even a bigger insult to have this included from system.h.
fcntl.h is standard, include it from places that need it and drop from system.h.
|
Added similar cleanup for fcntl.h, and rebased to fix conflict from the vfs-cleanup. |
|
Looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dirent.h and struct dirent are actually standard on this millenium, the
only thing that isn't is d_type member for which we have and retain
a specific test in configure.ac. Include <dirent.h> where needed,
relatively few places do which makes it even a bigger insult to have
this included from system.h.