Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on undefined macro uses in specs #1170

Closed
wants to merge 2 commits into from

Commits on Apr 8, 2020

  1. Warn on undefined macro uses in specs

    Implement a warn-on-undefined macro use flag in the macro engine, use
    when parsing specs. We only cover %{...} macros as specs consist of numerous
    directives starting with % that are not macros at all.
    
    This uncovers a mountain of dirt, including in our own test-suite.
    pmatilai committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    4d7b794 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2020

  1. Warn on undefined components in buildtree macros

    Use the new warning mechanism when expanding buildtree macros, such
    as things only defined during spec parse (eg %{name}). That always
    was a murky case that doesn't work in all scenarios, so a warning seems
    appropriate. There's a slight side-effect in that the macros get now
    expanded twice through rpmGetPath().
    pmatilai committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    19f44b8 View commit details
    Browse the repository at this point in the history