RFE: Support rpm version comparison in expressions #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is on top of #1221 as that is required for this to work, but in a separate PR to hopefully keep it more reviewable. We might want to add s"" as an alias to regular "" just for symmetry if/when this goes in, but leaving that out for now as it doesn't add anything new. |
|
So, this basically compares evrs, correct? |
hroncok
reviewed
May 19, 2020
Yes. It also has provisions for validating EVR strings, but the only validation currently done is that an EVR string cannot be empty. |
|
This looks good (only looking at the last three - parser related - patches). |
It's less code, less redundancy and makes adding new types nicer.
Less redundancy and makes adding new types nicer.
Adds rpm version as a new expression value type, denoted by v"" (similar
to Python u"", b"" etc), which are compared using rpm version comparison
algorithm rather than regular string comparison.
For example in specs:
%if v"%{python_version}" < v"3.9"
%endif
...but also command lines, arbitrary macros etc:
rpm --eval '%[v"1:1.2" < v"2.0"]'
Fixes: rpm-software-management#1217
|
Rebased. |
|
🎆 |
jessorensen
reviewed
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds rpm version as a new expression value type, denoted by v"" (similar to Python u"", b"" etc), which are compared using rpm version comparison algorithm rather than regular string comparison.
For example in specs:
...but also command lines, arbitrary macros etc:
rpm --eval '%[v"1:1.2" < v"2.0"]'Fixes: #1217