Remove deprecated beecrypt and NSS crypto backends #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beecrypt whose upstream is dead for more than ten years now, was deprecated in rpm 4.16 (in commit 0910e6a).
|
馃殌 馃憤 |
|
Flushing BDB down the same drain is really, really, really tempting 馃槆 but maybe not just yet... |
|
@pmatilai I think we need to deprecate it in 4.17 and ditch it in 4.18 while keeping bdb_ro only. |
|
Actually BDB too is already marked deprecated in 4.16 (commit fc0169e) |
|
@pmatilai oh, in that case - I would ditch bdb backend and possibly enable bdb_ro by default for 4.17 and then in 4.18 disable it by default. |
voxik
reviewed
May 28, 2020
|
@pmatilai Come on, drop BDB! Go for the gold! 馃 |
Conan-Kudo
approved these changes
May 28, 2020
Conan-Kudo
suggested changes
May 28, 2020
NSS is a behemoth of a library which drags in a whole runtime subsystem of its own which is often at odds with normal Unix system behavior (hello SIGPIPE). Now that we have nicer alternatives available there's little reason to lug this baggage along. NSS was deprecated in rpm 4.16 (commit 0b9efb9).
|
There's at least one thing that needs to be dealt with one way or the other before dropping BDB can be seriously considered: However 4.17 will NOT ship as BDB as the default, no matter what. |
|
Anyway, the DB discussion is a separate topic. Thanks for the doc review guys, fixed in the last push. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shedding some weight to celebrate the beginning of a new cycle 馃巻