Implement alternative transaction callback style #1365
Conversation
|
To clarify, in the C API the only change when the new mode is enabled, is the first callback-argument changing from a header to rpmte, ie (rpmte, what, amount, total, key, userdata). Key becomes redundant in this mode and could be dropped, because you can trivially get it from the rpmte now, but that would make this much more complicated for little to no gain, so leaving it alone. The Python callback is a very different animal. The old-style arguments are (what, amount, total, pkgObj, userdata), with pkgObj being either rpmteKey(), RPMTAG_NAME string or None. In this (draft) version, the arguments become: (rpmte, what, amount, total, userdata) in the new mode, ie almost the same as new mode C API. The question is whether we should make it the equivalent of the C API, ie with a "key" argument. It's redundant, so I'd kinda prefer to drop it from this new API, but then here's a chance to stop the forever old confusion due to Python and C callback being different... Thoughts? |
|
@pmatilai |
|
@jrohel , thanks for the feedback. Another option wrt Python callback could be just replacing the crazy pkgObj thing with rpmte, so the order and number of arguments would actually remain as it was, just that the weird pkgObj becomes actually meaningful, consistent and always present. Python being Python, this could be dynamically detected and handled compatibly with a callback that handles the old style too, but sometimes a clean break is better... |
|
Another thing to consider wrt the Python API is the way the new callback style is enabled. Here it's an added argument to ts.run() because that was the cheapest way to get it working, but testing for such a thing at runtime is not nice. Probably the better option would be just copying the C API, ie add a new ts.setCallbackStyle() method that persistently sets the style for a given ts. |
|
Updated for various fixes (mostly on Python side):
|
…ments Add API to get and set callback style, defaulting to the good ole header first style and add a new style where a transaction element is passed in place of the header, allowing a much saner interaction. This is doubly so in Python, where the old style callback is a braindamaged mess. In the new mode the "key" is not passed as separate argument at all, it can be just as well retrieved via te.Key() for the callbacks needing it.
|
Rebased to solve the conflict. |
|
Since there's no further feedback... (and there's still plenty of time to fine-tune details before next rpm release) |
Add API to get and set callback style, defaulting to the good ole
header first style and add a new style where a transaction element
is passed in place of the header, allowing a much saner interaction.
This is doubly so in Python, where the old style callback is a
braindamaged mess. In the new mode the "key" is not passed as separate
argument at all, it can be just as well retrieved via te.Key() for
the callbacks needing it.