Mark man pages with RPMFILE_MAN and info pages with RPMFILE_INFO #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define two additional file flags. One for man pages and one for info pages. These files are currently marked as RPMFILE_DOC during rpmbuild. This patch also marks man pages with RPMFILE_MAN and info pages with RPMFILE_INFO. The idea is that while they are still documentation, there will be further file flag details in the RPM header indicating what kind of docs they are. This patch could be extended to allow rpm to carry options like --excludeman and --excludeinfo, though if that happens the file flags may want to exclude man and info pages from RPMFILE_DOC entirely. My motivation for these additional file flags are for use in rpminspect when performing tests on man pages or info pages. Right now tools like rpminspect have to match man pages based on path and file type, which rpm already knows about. If the RPM header can carry a flag marking each man page, it makes tests in other tools easier. The same for info pages. Signed-off-by: David Cantrell <dcantrell@redhat.com>
|
Sorry but no: a bitfield does not scale for classifying individual file formats, and that's not what the virtual file attributes are for. A |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define two additional file flags. One for man pages and one for info pages. These files are currently marked as RPMFILE_DOC during rpmbuild. This patch also marks man pages with RPMFILE_MAN and info pages with RPMFILE_INFO. The idea is that while they are still documentation, there will be further file flag details in the RPM header indicating what kind of docs they are. This patch could be extended to allow rpm to carry options like --excludeman and --excludeinfo, though if that happens the file flags may want to exclude man and info pages from RPMFILE_DOC entirely.
My motivation for these additional file flags are for use in rpminspect when performing tests on man pages or info pages. Right
now tools like rpminspect have to match man pages based on path and file type, which rpm already knows about. If the RPM header can carry a flag marking each man page, it makes tests in other tools easier. The same for info pages.
Signed-off-by: David Cantrell dcantrell@redhat.com