Really require everything in buildroot to be packaged #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pmatilai This means that installed empty directories will get caught now too, right? |
|
Yes. That's exactly what the no longer failing testcase does (see the removed XFAIL in the patch) |
Previously we only checked for unpackaged files and symlinks, completely ignoring eg extra directories that might be there. Just check for everything instead. Related to rpm-software-management#994. Directories are a little tricky as some of them are almost always unowned so we need to allow all path components leading to packaged files. This would be a *lot* of relatively expensive lookups, but we only need to do the dance when the directory index changes, and we can stop when no new paths get added to the pool.
pmatilai
force-pushed
the
checkall-pr
branch
from
ad13225
to
e266345
Compare
|
Realized that we can (and should) optimize this considerably by avoiding redoing the path splitting for files in the same directory, and stopping on a given path when no new strings got added. This reduces the number of lookups for a simple testcase of fedora-release from ~300 to ~20, for large packages like the kernel the initial naive version would likely even show up in wall-clock... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we only checked for unpackaged files and symlinks, completely
ignoring eg extra directories that might be there. Just check for everything
instead. Related to #994.
Directories are a little tricky as some of them are almost always unowned
so we need to allow all path components leading to packaged files.