Exclude SIGALRM from the blocked signals #1479
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an alarm is set in one of the script in the RPM, it will be ignored because of the blocked signal. For example, if you use flock with -w, the alarm after the timeout will never be received: --- %pre flock -x -w 19 /tmp/lock sleep 99 ---
pmatilai
requested changes
Jan 8, 2021
There was a problem hiding this comment.
NAK, rpm does not want that signal. The shell invoking that command is a whole other question though.
I think the right thing to do here is to unblock all signals in the child after a successful fork in rpmscript.c. It's almost surprising we haven't had more bugs because of this.
|
As there has been no reaction, went ahead and implemented the suggested changes in a separate PR: #1486 Thanks for the patch though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an alarm is needed in one of the script in the RPM, it will be ignored because of the blocked signals.
For example, if you use flock with -w, the alarm after the timeout will never be received:
%pre
flock -x -w 19 /tmp/lock sleep 99