Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document dependency qualifiers (#1089) #1508

Merged
merged 1 commit into from Jan 19, 2021

Conversation

pmatilai
Copy link
Member

Add brief explanations on all our qualifiers and their semantics.
Also fix the terminology to use "qualifier" rather than "context".

Fixes: #1089

@ffesti
Copy link
Contributor

ffesti commented Jan 19, 2021

Looks good over all. May be there should be a more explicit emphasis that no qualifier (other than meta) is the "strongest" dependency as it does not allow the package to be removed. The only way to combine this with other qualifiers is to have two separate dependency statements.

@pmatilai
Copy link
Member Author

pmatilai commented Jan 19, 2021

%preun and %postun qualifiers also prevent removal, as does %verify, and maybe something else too. The key is not "strength", but rather the time of the dependency - %pre and %post are install-only dependencies, and actually so are %pretrans and %posttrans. Or at least should be.

We should actually make meta combined with any order-relevant qualifier an error...

Add brief explanations on all our qualifiers and their semantics.
Also fix the terminology to use "qualifier" rather than "context".

Fixes: rpm-software-management#1089
@pmatilai
Copy link
Member Author

Clarified the erasure behavior, documented it for pretrans and posttrans too, plus some formatting added.

@ffesti ffesti merged commit 965aae5 into rpm-software-management:master Jan 19, 2021
@pmatilai pmatilai deleted the depqual-pr branch February 19, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document dependency qualifiers
3 participants