Fix rpmtsInitDB() argument confusion #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since it's introduction, rpmtsInitDB() has passed the second argument directly to rpmdbInit() as permission bits. However commit 81fef98 incorrectly documented this as being related to the db mode read/write *mode*, and also used it that way in the python bindings.
Prior to this, ndb files were using hardcoded 0666 permissions whereas rpm generally defaults to 0644.
|
This is all more than just a little hysterical, our own Python bindings have been calling rpmtsInitDB() wrong since forever, presumably only saved by the sanity check for owner writability in newRpmdb(), and the fact that nobody has actually used it because of the implicit database initialization. With that gone, all these little creatures 🐛 🪲 are crawling into the daylight dazed and confused. We could just as well just make the dbmode argument unused and pass hardcoded 0644 downwards, because this all doesn't really matter that much. Other suggestions also welcome... |
mlschroe
approved these changes
Feb 2, 2021
Conan-Kudo
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it's introduction, rpmtsInitDB() has passed the second argument directly to rpmdbInit() as permission bits. However commit 81fef98 incorrectly documented this as being related to the db mode read/write mode, and also used it that way in the python bindings.
While looking at this, noticed that ndb passes hardcoded 0666 to open() whereas the rpm default open mode is 0644, use the API-requested mode instead. Sqlite doesn't seem to support passing a file mode request in the API (but it defaults to 0644 too).