Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Lua a hard requirement for rpm #1527

Merged
merged 1 commit into from Feb 9, 2021

Conversation

pmatilai
Copy link
Member

@pmatilai pmatilai commented Feb 4, 2021

More and more macros, scriptlets and other functionality has been getting
built around Lua, to the point that it has in practise been required for
several years now.

Maintaining the pretense of being optional comes at a cost in holding
back developments and having to check for that theoretical special
case. Lets make it a hard requirement and embrace it some more!

luaext/Makefile.am Outdated Show resolved Hide resolved
@Conan-Kudo
Copy link
Member

@pmatilai small nit of the commit message: "practise" -> "practice" (en-gb has the former for verb, but you're not using it that way, and en-us doesn't have that spelling at all).

@pmatilai
Copy link
Member Author

pmatilai commented Feb 8, 2021

Right, I have to say I seem to have forgotten that particular nuance of the English language. Will fix, but I have to say I was expecting somewhat more fundamental discussion over this matter 😆

@Conan-Kudo
Copy link
Member

Nah, this makes a ton of sense to do. At some point, I need to figure out how to do Lua for debbuild too. I just don't know how I'll square that with how Debian package scripts work...

More and more macros, scriptlets and other functionality has been getting
built around Lua, to the point that it has in practice been required for
several years now.

Maintaining the pretense of being optional comes at a cost in holding
back developments and having to check for that theoretical special
case. Lets make it a hard requirement and embrace it some more!
@pmatilai
Copy link
Member Author

pmatilai commented Feb 9, 2021

Spelling fixed...

@pmatilai
Copy link
Member Author

pmatilai commented Feb 9, 2021

Okay so nobody objects, even remotely, to the actual change. Except for myself, for whom this will make bisecting old stuff somewhat more difficult, but then ability to disable Lua only helps if the thing to bisect is not Lua. There's a price to everything, shrug.

@pmatilai pmatilai merged commit 7f3fdf6 into rpm-software-management:master Feb 9, 2021
@pmatilai pmatilai deleted the luareq-pr branch February 9, 2021 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants