Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpmsign: support EdDSA signatures #1571

Merged
merged 2 commits into from Mar 15, 2021

Conversation

DemiMarie
Copy link
Contributor

They were previously rejected

@pmatilai
Copy link
Member

It certainly is not an RSA signature. See the discussion in #1202 and related.
As the multiple signature support work hasn't progressed anywhere (and it wont anytime soon), perhaps we should consider just reusing the DSA tag for this afterall. I guess that's what @mlschroe originally had in mind?

@DemiMarie
Copy link
Contributor Author

It certainly is not an RSA signature. See the discussion in #1202 and related.
As the multiple signature support work hasn't progressed anywhere (and it wont anytime soon), perhaps we should consider just reusing the DSA tag for this afterall. I guess that's what @mlschroe originally had in mind?

I don’t particularly care which tag is used, so long as it works. Can we eliminate the distinction in RPMv6?

Users can pass untrusted data to hdrblobInit() and it must be robust
against this.
They were previously rejected
@pmatilai
Copy link
Member

Seems like a revised version of #1500 accidentally ended up in this PR. No matter, I far prefer this version and splitting this to yet more PR's wouldn't actually help anything. Also, @mlschroe seems to be busy but he did indicate the preference for existing tags in #1202 so...

Thanks for the patches!

@pmatilai pmatilai merged commit 23770e1 into rpm-software-management:master Mar 15, 2021
@DemiMarie DemiMarie deleted the eddsa-rpmsign branch March 15, 2021 15:13
@Conan-Kudo
Copy link
Member

I don’t particularly care which tag is used, so long as it works. Can we eliminate the distinction in RPMv6?

We'd need some way to tell what keys are what type, but there are certainly better ways to do it. Ideally, RPMv6 would also include fixing support for multiple signatures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants