Really deprecate headerLoad(), headerCopyLoad() and headerUnload() #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no way to safely validate an object to which only a void pointer is given. Use headerImport() and pass a size to make verification possible, headerCopyLoad() has been long deprecated anyway.
headerLoad(), headerCopyLoad() and headerUnload() have been deprecated as unsafe since rpm 4.10, time to start pushing them out for real. The first two are unsafe because they don't take argument for size, the last one is because it doesn't return one so it forces using the unsafe variants.
Conan-Kudo
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
headerLoad(), headerCopyLoad() and headerUnload() have been deprecated as unsafe since rpm 4.10, time to start pushing them out for real. The first two are unsafe because they don't take argument for size, the last one is because it doesn't return one so it forces using the unsafe variants.
Eliminate remaining in-tree uses of the unsafe variants and issue compile-time deprecation warnings on them now that we can.