Check for overflow in computing blob->rdl #1583
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using GCC’s overflow-checking builtins, we avoid needing to reason about overflow manually, which is error-prone. Having GCC do the arithmetic in infinite signed precision is much nicer. This was assigned CVE-2021-20249. I do not believe it is practically exploitable, but it should still be fixed.
|
That CVE is not even public yet! Besides that, we can't use random compiler specific helpers like that. NAK. If you report a vulnerability through the security process, you need to let that process run its course. Please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using GCC’s overflow-checking builtins, we avoid needing to reason
about overflow manually, which is error-prone. Having GCC do the
arithmetic in infinite signed precision is much nicer.
I am making this PR because this overflow was assigned CVE-2021-20249.