Fix logic error in macro file reader #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old logic always finished adding lines if an empty line was encountered, because the check that should guard against accessing outside of the read buffer was done at the wrong level. Also simplify the code by letting 'q' point to the new line and not before the newline, which also fixes potential undefined behaviour. Also get rid of the unused 'nread' variable.
|
Oh, nice. Besides fixing a concrete parser bug (there actually is even an RFE to support those empty lines, #580) it gets rid of the shady code as well. Thanks! |
This was referenced Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old logic always finished adding lines if an empty line
was encountered, because the check that should guard against
accessing outside of the read buffer was done at the wrong
level.
Also simplify the code by letting 'q' point to the new line and
not before the newline, which also fixes potential undefined
behaviour.
Also get rid of the unused 'nread' variable.