Check that padding is zeroed and regions are consistent #1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DemiMarie
force-pushed
the
padding-zeroed
branch
from
58c8d0f
to
40443f6
Compare
|
@ffesti would you mind looking at this? |
DemiMarie
force-pushed
the
padding-zeroed
branch
from
e4a5035
to
36a8ff7
Compare
This adds checks that padding is zeroed and that regions are internally consistent. It also adds a check that the padding is of minimum length. Fixes rpm-software-management#1572.
Already done by regionSwab(), but regionSwab() should not need to do that.
This will only fire if there is a bug in RPM, not if the input package is bad.
DemiMarie
force-pushed
the
padding-zeroed
branch
from
dff5ec6
to
0a19ea5
Compare
|
Sorry but NAK, see #1559 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds checks that padding is zeroed and that regions are internally
consistent. It also adds a check that the padding is of minimum length.
Fixes #1572.