Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1473: move option -q to rpmQueryPoptTable #1656

Closed
wants to merge 52 commits into from

Conversation

yecril71pl
Copy link
Contributor

This is obviously work in progress. Please let me know whether I can go forward like that.

@ffesti
Copy link
Contributor

ffesti commented Apr 26, 2021

The pull request should only have the one relevant patch. Please rebase the patch to the current master branch.

The patch is also missing a justification for the change. This should be part of the commit message. But even ignoring the commit message I don't quite see what you are trying to achive here. Why should there be a options to query if there are options what exactly to query for?

@yecril71pl
Copy link
Contributor Author

yecril71pl commented Apr 27, 2021

The short of it: I am trying to make the test of 5ee6394 pass. This patch is relevant because it introduces the test. Everything leading to it is also relevant because otherwise I would not be able to run the test.
The long of it is discussed at Issue #1473.
Do you want me to compress the whole change into one patch?
However, the failing test means I have broken something so my submission is no good.

@yecril71pl yecril71pl closed this Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants