Load plugin library symbols first #1664
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I understand the issue of symbols of the plugin vs system symbols as both may be linked to different versions of a library or symbols may collide otherwise. I am just not quite sure how or if at all this relates to RTLD_LAZY vs RTLD_NOW. So while the change may be OK I wonder if the commit message is capturing the right reasons. |
|
@ffesti, i see what you mean, i will change it, thanks |
dlopen the plugin librairies with RTLD_BINDDEEP flag avoid collide with system libraries by first loading plugin symbols before system symbols Fixes: rpm-software-management#1663
|
If I understand the ticket correctly, this is solving the wrong problem. With the exception of |
|
See above, I think this is addressing the wrong end of the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dlopen load plugins LIBRARY with RTLD_LAZY flag
it means the symbols are loaded when references are executed
so it causes issue when some references are the same than in system
append RTLD_BINDDEEP allows to first load symbols from the plugin library
Fixes: #1663