macros: Add %remove_installed_la_files #1674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would just replace one line of boilerplate with another. Lets rather add a brp-script which removes the .la files by default, and then the handful of packages that actually do want to ship those files can simply disable the brp policy. |
|
Sounds good, I tried doing that. |
|
Sorry, missed the broken CI before. |
pmatilai
reviewed
Jun 10, 2021
.la files are libtool files and should generally not be installed. Tons of spec files contain a 'find' command to remove them. Add a helper script that automatically removes all .la files from the build root and let projects that need them opt out of this instead.
tbaederr
force-pushed
the
remove-la-files
branch
from
59bbe47
to
e22ca5c
Compare
|
Looks fine now. Thanks for the patch! |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of packages remove .la files via
find $RPM_BUILD_ROOT -name "*.la" -delete
or similar. Add %remove_installed_la_files to standardize this.
I could not find tests for the macros in the rpm repository, but I testes this separately in a spec file. I went with
-deletehere and notexec rm -f {} \;. It might also be worthwhile to add-printas well.Thoughts?