Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OpenPGP parsing bugs #1675

Closed
wants to merge 1 commit into from
Closed

Fix OpenPGP parsing bugs #1675

wants to merge 1 commit into from

Conversation

DemiMarie
Copy link
Contributor

  • signatures of the wrong type were accepted
  • signatures were allowed to contain multiple packets
  • numerous out-of-bounds reads
  • undefined pointer arithmetic

@DemiMarie
Fix OpenPGP parsing bugs
139eac1 
- signatures of the wrong type were accepted
- signatures were allowed to contain multiple packets
- numerous out-of-bounds reads
- undefined pointer arithmetic
@DemiMarie DemiMarie mentioned this pull request May 6, 2021
Closed
@DemiMarie
Copy link
Contributor Author

@dmach @Conan-Kudo

@pmatilai
Copy link
Member

pmatilai commented May 6, 2021

As I've said over and over, we will never accept such a large lump of a commit in a single go. This is all far better split up into individual commits in #1612. Why are you filing duplicates of your own work?

PLEASE STOP THIS.

@pmatilai pmatilai closed this May 6, 2021
@DemiMarie
Copy link
Contributor Author

As I've said over and over, we will never accept such a large lump of a commit in a single go. This is all far better split up into individual commits in #1612. Why are you filing duplicates of your own work?

PLEASE STOP THIS.

#1612 is for non-security improvements, while this is for changes that have a security impact and should be reviewed with higher priority. I am more than willing to split up the patch, though!

@DemiMarie DemiMarie deleted the openpgp-parse-no-undefined-behavior branch March 22, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DemiMarie @pmatilai