Allow certain tags in either header #1680
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works around an install4j bug: it generated an RPMTAG_ARCHIVESIZE tag in the main header. It also fixes support for packages with file signatures generated by old versions of RPM, which included them in the main header. Including file signatures in the main header actually has advantages over including them in the signature header and should not be forbidden.
DemiMarie
force-pushed
the
allow-broken-install4j-packages
branch
from
33afade
to
c1989f8
Compare
|
Replaced by #1688. Thanks for your effort, but in many cases it's far more easier and efficient for us to fix our own instead of reviewing external code, arguing over and explaining finer details to get the commit messages just so etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around an install4j bug: it generated an RPMTAG_ARCHIVESIZE
tag in the main header. It also fixes support for packages with file
signatures generated by old versions of RPM, which included them in the
main header. Including file signatures in the main header actually has
advantages over including them in the signature header and should not be
forbidden.
Fixes #1635.