Bump the Lua minimum version to 5.3. #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 986be66 commit introduced a use of lua_rotate(), which is not available in Lua 5.2.
|
Yes, something needs to be done here. I am not merging this right away, as we are pretty late in 4.17 and I am not that much into this code. Bumping required versions for something like lua requires a bit of consideration (although lua 5.3 is probably fine). As it is vacation time this may take a while, but we will definitely do something about this before the 4.17 release. Thanks for the report (and patch)! |
Conan-Kudo
approved these changes
Jul 2, 2021
pmatilai
requested changes
Aug 5, 2021
pmatilai
approved these changes
Aug 6, 2021
|
Thanks for spotting this and the patch! |
pmatilai
pushed a commit
to pmatilai/rpm
that referenced
this pull request
Aug 19, 2021
Bump the Lua minimum version to 5.3. The 986be66 commit introduced a use of lua_rotate(), which is not available in Lua 5.2, unintentionally causing a dependency on 5.3. Rather than work around it, just bump the requirement to 5.3, it's almost seven years old by now... (cherry picked from commit 24b6c45)
pmatilai
pushed a commit
that referenced
this pull request
Aug 20, 2021
Bump the Lua minimum version to 5.3. The 986be66 commit introduced a use of lua_rotate(), which is not available in Lua 5.2, unintentionally causing a dependency on 5.3. Rather than work around it, just bump the requirement to 5.3, it's almost seven years old by now... (cherry picked from commit 24b6c45)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
First of all, thanks a lot for working on rpm and the related projects!
The 986be66 commit introduced a use of
lua_rotate(), which is not available in Lua 5.2. Hence, bump the dependency in
the configure script's pkg-config check.
Thanks in advance for your time, and keep up the great work!
G'luck,
Peter