Fix fstat64 handling on macOS with Apple Silicon #1775
Conversation
The Apple Silicon toolchain removes the *64 stat symbols (deprecated since 10.6) in favour of their unprefixed form. This change might not work properly before 10.6, but 10.5 has been out of support for over a decade, so that hopefully shouldn't be relevant. Fixes rpm-software-management#1752.
emilazy
force-pushed
the
fix-fts-apple-silicon
branch
from
0abc07d
to
45120e7
Compare
|
(Rebased to use hard tabs.) |
|
Thanks for the patch! |
|
Hi 👋🏼. First of all, thanks for looking into this. We are experiencing issues when we try to build from the source through Homebrew. Is there anything else that needs to be done for the fix to work? |
|
This commit was merged on 2021-09-14 but the latest rpm release is from 2021-09-03; Homebrew would have to apply this patch on top in order to have a working Apple Silicon build before the next upstream release. |
|
I applied the patch here on my fork here: tormodatt/homebrew-core@d5cdc57, which makes it build, but I get: any ideas? |
|
This seems to have broken the build on Intel Macs, since we tried applying this patch and found we needed to make it conditional on ARM macOS. See Homebrew/homebrew-core#93683. |
|
Sir, this is a Wendy's! As much as we want RPM to work everywhere and for everyone this is a discussion that belongs in the Homebrew project and not here. |
Does it? Note that this affects non-Homebrew users too, so it seems odd to say the discussion only belongs there. |
|
Oh, sorry. I assumed that this is an release engineering issue. If there is an issue with the patch this clearly belongs here on Git Hub. Still discussing it in an closed PR is less then ideal. May be open a new ticket as this will get peoples attention. |
|
The missing lua symbol very much hints to some issue with the lua library used for the built. So chances are this is a issue unrelated to the patch. |
|
I would agree with you, if the issue we were having is a missing Lua symbol. I wouldn't have posted here if it were. I'll open an issue with a better description of the problem tomorrow. |
|
Sent a patch instead: #1897 |
This contribution uses an upstream fix rpm-software-management/rpm#1775 To limit the chances of breaking other architectures or systems the patch is only used when we target darwin aarch64.
The Apple Silicon toolchain removes the *64 stat symbols (deprecated
since 10.6) in favour of their unprefixed form.
This change might not work properly before 10.6, but 10.5 has been out
of support for over a decade, so that hopefully shouldn't be relevant.
Fixes #1752.