Require package names to be valid provides #1778
Conversation
build/rpmbuild_internal.h
Outdated
| @@ -19,6 +19,7 @@ | |||
| #undef HTDATATYPE | |||
|
|
|||
| #define ALLOWED_CHARS_NAME ".-_+%{}" | |||
| #define ALLOWED_FIRSTCHARS_NAME "_%{}" | |||
There was a problem hiding this comment.
Doh, I missed the actual beef of the change there (once again...)
While we need to accept %{} from macro leakage in the names, { and } are not actually valid as the first characters.
There was a problem hiding this comment.
Ok, after reading rpmCharCheck() 3 more times: Looks like %{}are actually legal in dependency names and only create a warning. So they must not be in the first character.
There was a problem hiding this comment.
Took a bit of digging, but here's the case for unexpanded macros in the names etc:
https://bugzilla.redhat.com/show_bug.cgi?id=547997 and commit 507f21f.
So as I tried to say in my previous comment, I think you'd still need to allow % as the first character.
There was a problem hiding this comment.
OK, so this is not by accident but to not blow up for unexpanded macros that may just not be available at that point in time.
Only allow alphanumeric or _ as first character. Also check the name of Obsoletes. Resolves: rpm-software-management#1694
|
Going forward, we should probably look into replacing this silly rpmCharCheck() thing with regular expressions... |
Only allow alphanumeric or _ as first character.
Also check the name of Obsoletes.
Resolves: #1694