Don't strip *.go and ELF files with "no maschine" #1780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as those may be Guile object files. Those are ELF files but cannot be stripped. This may also exclude other files (like Golang sources) but that should not be an issue. Resolves: rpm-software-management#1765
as strip fails on them (if they are Guile object files). This adds another layer of protection as *.go files are already filtered out. Resolves: rpm-software-management#1765
pmatilai
approved these changes
Sep 27, 2021
|
I talked to mjw about this. eu-strip would probably be able to strip even these Guile files. I don't really know whether they should be stripped or not, though. Excluding the Golang (source) files should really not matter but this is to be on the save side. And yes this whole brp business screams for a better solution but I just want this error to go away for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not 100% sure if this "no machine" business is 100% correct. But it looks like a better defense against
stripfailing than relying on the file name alone.