Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpmscript: Include lib/rpmchroot.h for rpmChrootOut() #2152

Closed
wants to merge 1 commit into from

Conversation

kraj
Copy link

@kraj kraj commented Aug 16, 2022

This fixes implicit function declarations warning

Signed-off-by: Khem Raj raj.khem@gmail.com

This fixes implicit function declarations warning

Signed-off-by: Khem Raj <raj.khem@gmail.com>
@pmatilai
Copy link
Member

There are no rpmChroot*() calls whatsoever in lib/rpmscript.c:

[pmatilai🎩︎localhost rpm]$ grep -l rpmChroot lib/*.c
lib/psm.c
lib/rpmchroot.c
lib/rpmdb.c
lib/rpmts.c
lib/transaction.c
lib/verify.c

Nor should there, the chroot state needs to be managed from higher level.

@pmatilai pmatilai closed this Aug 17, 2022
@kraj
Copy link
Author

kraj commented Aug 17, 2022

my bad, it was a local commit which had this change and that needs to be submitted along with this change squashed thanks.

@kraj kraj deleted the kraj/clang15 branch August 17, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants