Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Python egg-info from automake builds (4.18.x) #2341

Merged
merged 1 commit into from Jan 10, 2023

Conversation

pmatilai
Copy link
Member

@pmatilai pmatilai commented Jan 9, 2023

To compensate for the loss of egg-info from the python distutils build, create one ourselves.

This is effectively a backport of e31fb5b which dismissed the need for an automake version, but unfortunately Python 3.12 and automake-based rpm versions do co-exist in the same time-space continuum and we'll have to deal with this in rpm 4.18 as well.

As to why not just use distutils from python-setuptools: that variant turns the egg-info into a directory, which in rpm is a one-way street. And we don't need that multi megabyte Python library to fill in these couple of values, really.

To compensate for the loss of egg-info from the python distutils build,
create one ourselves.

This is effectively a backport of e31fb5b
which dismissed the need for an automake version, but unfortunately Python
3.12 and automake-based rpm versions do co-exist in the same time-space
continuum and we'll have to deal with this in rpm 4.18 as well.

As to why not just use distutils from python-setuptools: that variant
turns the egg-info into a directory, which in rpm is a one-way street.
And we don't need that multi megabyte Python library to fill in these
couple of values, really.
@pmatilai pmatilai added the python Python bindings label Jan 9, 2023
@pmatilai pmatilai changed the title Generate Python egg-info from automake builds Generate Python egg-info from automake builds (4.18.x) Jan 9, 2023
Copy link
Member

@Conan-Kudo Conan-Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blech. Fine...

@pmatilai
Copy link
Member Author

My sentiments exactly...

@pmatilai pmatilai merged commit 35c62dc into rpm-software-management:rpm-4.18.x Jan 10, 2023
@pmatilai pmatilai deleted the pyegg branch January 10, 2023 09:10
@pmatilai pmatilai added this to the 4.18.1 milestone Jan 10, 2023
@pmatilai
Copy link
Member Author

Just noting that this will need a mention in the release notes when the time comes: the setup.py build is not compatible with Python >= 3.12

@pmatilai pmatilai self-assigned this Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Python bindings
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants