Allow setting platform macro settings externally #2585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 26, 2023
Conan-Kudo
suggested changes
Jul 26, 2023
INSTALL
Outdated
Comment on lines
151
to
154
| This is enough for regular Linux distributions, except Yocto. Yocto has | ||
| so called Board Support Packages (BSPs) that cover more than the CPU | ||
| architectures. These BSPs cover specific single board computer systems. | ||
| Examples of such BSP names: |
There was a problem hiding this comment.
Can you reword this to not require knowing what Yocto is? That is, if Yocto disappeared tomorrow, we wouldn't have a good reference for the need for this feature.
While we want to serve and support distributions, we try to ensure our features aren't "distro-dependant", so if the documentation on this can be made compelling without singling out or requiring to know Yocto, that would significantly help.
INSTALL
Outdated
Comment on lines
151
to
154
| This is enough for regular Linux distributions, except Yocto. Yocto has | ||
| so called Board Support Packages (BSPs) that cover more than the CPU | ||
| architectures. These BSPs cover specific single board computer systems. | ||
| Examples of such BSP names: |
There was a problem hiding this comment.
Can you reword this to not require knowing what Yocto is? That is, if Yocto disappeared tomorrow, we wouldn't have a good reference for the need for this feature.
While we want to serve and support distributions, we try to ensure our features aren't "distro-dependant", so if the documentation on this can be made compelling without singling out or requiring to know Yocto, that would significantly help.
There was a problem hiding this comment.
I refreshed the commit message and INSTALL. Please re-read it. Thanks.
INSTALL
Outdated
Comment on lines
172
to
174
| To allow creating the macros file for such a custom platform (only one | ||
| needed for a specific BSP build in Yocto), the shell variables listed below | ||
| must be set. If RPM_CUSTOM_ARCH is not set, the rest is ignored. |
By default, rpm installs a series of default platforms based on
the CPU architecture names in subdirectories called
/usr/lib/platform/<arch>-linux
This is enough for regular Linux distributions. However, some
distributions may use more specific platform names that refer to
particular computer systems, like SBCs or specific CPU tuning when
compiling.
If the platform subdirectory does not exist in /usr/lib/platform
then rpmbuild does not work.
Allow creating such custom platform subdirectory with feeding
the necessary data using external variables: RPM_CUSTOM_ARCH,
RPM_CUSTOM_ISANAME, RPM_CUSTOM_ISABITS, RPM_CUSTOM_CANONARCH
and RPM_CUSTOM_CANONCOLOR
Signed-off-by: Zoltán Böszörményi <zboszor@gmail.com>
zboszor
force-pushed
the
allow-rpm-macros-template
branch
from
14840d0
to
98a7615
Compare
Conan-Kudo
approved these changes
Jul 26, 2023
Don't present "linux" as the only possible value of OS
|
Adjusted the docs a bit to not assume platform is always "linux" - even if it is for many people. |
kraj
pushed a commit
to YoeDistro/poky
that referenced
this pull request
Jul 28, 2023
Feed platform settings to installplatform externally. Based on the patch submitted under rpm-software-management/rpm#2585 Patch against INSTALL was backported for rpm 4.18.1 (From OE-Core rev: 29b568878d6094afd93bdd90f6f68dc3a6db439c) Signed-off-by: Zoltán Böszörményi <zboszor@gmail.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
dmnks
pushed a commit
to dmnks/rpm
that referenced
this pull request
Aug 1, 2023
…ment#2585) * Allow setting platform macro settings externally By default, rpm installs a series of default platforms based on the CPU architecture names in subdirectories called /usr/lib/platform/<arch>-<os> This is enough for regular Linux distributions. However, some distributions may use more specific platform names that refer to particular computer systems, like SBCs or specific CPU tuning when compiling. If the platform subdirectory does not exist in /usr/lib/platform then rpmbuild does not work. Allow creating such custom platform subdirectory with feeding the necessary data using external variables: RPM_CUSTOM_ARCH, RPM_CUSTOM_ISANAME, RPM_CUSTOM_ISABITS, RPM_CUSTOM_CANONARCH and RPM_CUSTOM_CANONCOLOR Signed-off-by: Zoltán Böszörményi <zboszor@gmail.com> --------- Signed-off-by: Zoltán Böszörményi <zboszor@gmail.com> Co-authored-by: Florian Festi <ffesti@redhat.com> (cherry picked from commit fde03ae)
dmnks
pushed a commit
that referenced
this pull request
Aug 1, 2023
* Allow setting platform macro settings externally
By default, rpm installs a series of default platforms based on
the CPU architecture names in subdirectories called
/usr/lib/platform/<arch>-<os>
This is enough for regular Linux distributions. However, some
distributions may use more specific platform names that refer to
particular computer systems, like SBCs or specific CPU tuning when
compiling.
If the platform subdirectory does not exist in /usr/lib/platform
then rpmbuild does not work.
Allow creating such custom platform subdirectory with feeding
the necessary data using external variables: RPM_CUSTOM_ARCH,
RPM_CUSTOM_ISANAME, RPM_CUSTOM_ISABITS, RPM_CUSTOM_CANONARCH
and RPM_CUSTOM_CANONCOLOR
Signed-off-by: Zoltán Böszörményi <zboszor@gmail.com>
---------
Signed-off-by: Zoltán Böszörményi <zboszor@gmail.com>
Co-authored-by: Florian Festi <ffesti@redhat.com>
(cherry picked from commit fde03ae)
kraj
pushed a commit
to YoeDistro/poky
that referenced
this pull request
Aug 1, 2023
Feed platform settings to installplatform externally. Based on the patch submitted under rpm-software-management/rpm#2585 Patch against INSTALL was backported for rpm 4.18.1 (From OE-Core rev: 1c3b7f610645363d073d7c2f165d4f56eeab1ad8) Signed-off-by: Zoltán Böszörményi <zboszor@gmail.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, rpm installs a series of default platforms based on the CPU architecture names in subdirectories called
/usr/lib/platform/<arch>-linux.This is enough for regular Linux distributions. However, some distributions may use more specific platform names that refer to particular computer systems, like SBCs or specific CPU tuning when compiling.
If the platform subdirectory does not exist in
/usr/lib/platformthen rpmbuild does not work.Allow creating such custom platform subdirectory with feeding the necessary data using external variables:
RPM_CUSTOM_ARCH,RPM_CUSTOM_ISANAME,RPM_CUSTOM_ISABITS,RPM_CUSTOM_CANONARCHandRPM_CUSTOM_CANONCOLORFixes #2578