Add a Provides generator for rpm lua modules #2659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some packages in Fedora provide shared RPM lua code that's used by other packages. It would be nice to have automatic Provides for this code like we have for rpm macros themselves. Usecase: Recently, forge.lua that's used by go-srpm-macros and fonts-srpm-macros moved out of redhat-rpm-config. I would like to be able to add `Requires: rpm_lua(fedora.srpm.forge)` to those packages instead of having to rely on it being implicitly pulled in by redhat-rpm-config or adding conditional dependencies on forge-srpm-macros.
|
I don't see a reason not to... Thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some packages in Fedora provide shared RPM lua code that's used by other packages.
It would be nice to have automatic Provides for this code like we have for rpm macros themselves.
Usecase:
Recently, forge.lua that's used by go-srpm-macros and fonts-srpm-macros moved out of redhat-rpm-config.
I would like to be able to add
Requires: rpm_lua(fedora.srpm.forge)to those packages instead of having to rely on it being implicitly pulled in by redhat-rpm-config or adding conditional dependencies on forge-srpm-macros.