Public rpmpgp.h header mass cleanup #2717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RFC's are online accessible to everybody, no reason to carry a copy of an outdated draft in rpm. Remove unused structs, and move used ones into the internal parser. Nothing else needs this stuff, never has. No functional changes.
|
@nwalfield, just FYI |
|
You've removed types from the public API. Are you sure that is okay? |
|
Yes - there's nothing in our API that exposes data through those structs. If somebody has been basing their own parser by including that header then .. they're just going to have to invent their own structs now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RFC's are online accessible to everybody, no reason to carry a copy of an outdated draft in rpm.
Remove unused structs, and move used ones into the internal parser. Nothing else needs this stuff, never has.
No functional changes.