Build all manuals regardless of enabled features #2804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 1870f4d stopped the installation of man pages for disabled features. We were still building them all, though, so they appeared in dist tarballs as they should have. This was lost in the cmake translation where the opposite problem was introduced: only man pages for enabled features are now built, meaning that when preparing a tarball, you need to make sure all the features are enabled in your build in order to have all the man pages pre-built and bundled. Fix this "regression" by building all man pages unconditionally again while only installing those that are enabled.
No functional changes, just reduces verbosity a bit.
dmnks
changed the title
dmnks
added a commit
to dmnks/rpm-web
that referenced
this pull request
Dec 7, 2023
This is no longer needed with rpm-software-management/rpm#2804.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the first commit for details.