Add LMDB backend for RPMDB to RPM (from @n3npq in #281) #291
Conversation
Conan-Kudo
changed the title
|
Is it intended, that it's called |
|
@n3npq why don't you send Pull Requests on your own. finding this attachments and converting them to real commits is painful and doesn't lead anywhere... |
Conan-Kudo
force-pushed
the
rpm-lmdb
branch
2 times, most recently
from
c8281d0
to
2864bc4
Compare
|
@n3npq @hyc @ignatenkobrain This should be fully rebased now. |
|
Please remove the part that patches ndb/glue.c from this commit. |
|
@mlschroe Fixed. |
Conan-Kudo
changed the title
Conan-Kudo
changed the title
Conan-Kudo
force-pushed
the
rpm-lmdb
branch
4 times, most recently
from
d5881e6
to
71c4ced
Compare
v2 (Neal Gompa) * Switch from RPM_CHECK_LIB to PKG_CHECK_MODULES * Fix notation of file name in lmdb.c * Remove MDB_FIXEDMAP flag to prevent portability issues * Rename database file "data.mdb" to "Packages.mdb" * Add comment that lmdb is an option for %_db_backend Closes: rpm-software-management#281 Fixes: rpm-software-management#128
|
@n3npq : well this is a pleasant surprise. Thank you! @Conan-Kudo : testing for Packages.mdb existence doesn't make LMDB create it. AFAICS the "data.mdb" name is hardwired in LMDB unless MDB_NOSUBDIR is used, and using that would introduce other unnecessary complications. I can fix that when committing. Other than that, there seems to be some code duplication from db3.c that could be eliminated with a bit of refactoring and other more or less minor cleanups, but those can be dealt with later on as time permits. |
|
Merged manually as of commit ed9de19 Again, thank you @n3npq for the backend and @Conan-Kudo for the final tweaks! |
|
@pmatilai Thank you for reviewing it! |
This PR implements an LMDB-based rpmdb for RPM.
Closes #281
Fixes #128