New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LMDB backend for RPMDB to RPM (from @n3npq in #281) #291

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@Conan-Kudo
Member

Conan-Kudo commented Jul 30, 2017

This PR implements an LMDB-based rpmdb for RPM.

Closes #281
Fixes #128

@Conan-Kudo Conan-Kudo changed the title from Add LMDB backend for RPMDB to RPM to Add LMDB backend for RPMDB to RPM (from @n3npq in #281) Jul 30, 2017

@robert-scheck

This comment has been minimized.

Show comment
Hide comment
@robert-scheck

robert-scheck Jul 30, 2017

Is it intended, that it's called /data.mdb rather /Packages.mdb?

robert-scheck commented Jul 30, 2017

Is it intended, that it's called /data.mdb rather /Packages.mdb?

@ignatenkobrain

This comment has been minimized.

Show comment
Hide comment
@ignatenkobrain

ignatenkobrain Jul 30, 2017

Member

@n3npq why don't you send Pull Requests on your own. finding this attachments and converting them to real commits is painful and doesn't lead anywhere...

Member

ignatenkobrain commented Jul 30, 2017

@n3npq why don't you send Pull Requests on your own. finding this attachments and converting them to real commits is painful and doesn't lead anywhere...

@Conan-Kudo

This comment has been minimized.

Show comment
Hide comment
@Conan-Kudo

Conan-Kudo Jul 30, 2017

Member

@n3npq @hyc @ignatenkobrain This should be fully rebased now.

Member

Conan-Kudo commented Jul 30, 2017

@n3npq @hyc @ignatenkobrain This should be fully rebased now.

@mlschroe

This comment has been minimized.

Show comment
Hide comment
@mlschroe

mlschroe Jul 31, 2017

Contributor

Please remove the part that patches ndb/glue.c from this commit.

Contributor

mlschroe commented Jul 31, 2017

Please remove the part that patches ndb/glue.c from this commit.

@Conan-Kudo

This comment has been minimized.

Show comment
Hide comment
@Conan-Kudo
Member

Conan-Kudo commented Jul 31, 2017

@mlschroe Fixed.

@Conan-Kudo Conan-Kudo changed the title from Add LMDB backend for RPMDB to RPM (from @n3npq in #281) to WIP: Add LMDB backend for RPMDB to RPM (from @n3npq in #281) Aug 10, 2017

@Conan-Kudo Conan-Kudo changed the title from WIP: Add LMDB backend for RPMDB to RPM (from @n3npq in #281) to Add LMDB backend for RPMDB to RPM (from @n3npq in #281) Aug 10, 2017

n3npq and others added some commits Jul 30, 2017

Add LMDB backend to RPM
v2 (Neal Gompa)
  * Switch from RPM_CHECK_LIB to PKG_CHECK_MODULES
  * Fix notation of file name in lmdb.c
  * Remove MDB_FIXEDMAP flag to prevent portability issues
  * Rename database file "data.mdb" to "Packages.mdb"
  * Add comment that lmdb is an option for %_db_backend

Closes: #281
Fixes: #128
@pmatilai

This comment has been minimized.

Show comment
Hide comment
@pmatilai

pmatilai Aug 17, 2017

Contributor

@n3npq : well this is a pleasant surprise. Thank you!

@Conan-Kudo : testing for Packages.mdb existence doesn't make LMDB create it. AFAICS the "data.mdb" name is hardwired in LMDB unless MDB_NOSUBDIR is used, and using that would introduce other unnecessary complications. I can fix that when committing.

Other than that, there seems to be some code duplication from db3.c that could be eliminated with a bit of refactoring and other more or less minor cleanups, but those can be dealt with later on as time permits.

Contributor

pmatilai commented Aug 17, 2017

@n3npq : well this is a pleasant surprise. Thank you!

@Conan-Kudo : testing for Packages.mdb existence doesn't make LMDB create it. AFAICS the "data.mdb" name is hardwired in LMDB unless MDB_NOSUBDIR is used, and using that would introduce other unnecessary complications. I can fix that when committing.

Other than that, there seems to be some code duplication from db3.c that could be eliminated with a bit of refactoring and other more or less minor cleanups, but those can be dealt with later on as time permits.

@pmatilai

This comment has been minimized.

Show comment
Hide comment
@pmatilai

pmatilai Aug 17, 2017

Contributor

Merged manually as of commit ed9de19

Again, thank you @n3npq for the backend and @Conan-Kudo for the final tweaks!

Contributor

pmatilai commented Aug 17, 2017

Merged manually as of commit ed9de19

Again, thank you @n3npq for the backend and @Conan-Kudo for the final tweaks!

@pmatilai pmatilai closed this Aug 17, 2017

@Conan-Kudo Conan-Kudo deleted the Conan-Kudo:rpm-lmdb branch Aug 17, 2017

@Conan-Kudo

This comment has been minimized.

Show comment
Hide comment
@Conan-Kudo

Conan-Kudo Aug 17, 2017

Member

@pmatilai Thank you for reviewing it!

Member

Conan-Kudo commented Aug 17, 2017

@pmatilai Thank you for reviewing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment