Document fork, exec, wait and redirect2null Lua functions as deprecated #2948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We probably should also issue warnings on execution... |
|
The changes look good. But we need to add the warning right away before this PR closes #2420 |
|
Yup. The reason the warnings are not there yet is that I'm wondering how meaningful they are in reality, ie does it reach the right audience or will it be only an annoyance to end users who can't do the damnest thing about it. But then, nobody will notice a piece of documentation changing. |
Rpm scriptlets should have no business dealing with this level of detail in process control, rpm.execut() is much saner and safer for scriptlet needs. We can't just remove because this is a public API with known users (eg glibc in Fedora), but we can at least document these as deprecated with noisy warnings. fork() and exec() are the main "problems" here, but wait() and redirect2null() become meaningless once you take the first two away. Fixes: rpm-software-management#2420
|
Added note about the removal schedule, and noisy deprecation warnings on every use to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rpm scriptlets should have no business dealing with this level of detail in process control, rpm.execut() is much saner and safer for scriptlet needs. We can't just remove because this is a public API with known users (eg glibc and setup in Fedora), but we can at least document these as deprecated.
fork() and exec() are the main "problems" here, but wait() and redirect2null() become meaningless once you take the first two away.
Fixes: #2420