Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Really allow qualifiers like pre/post/meta for weak dependencies #2964

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

pmatilai
Copy link
Member

Commit ddbf30c neglected to update the preamble table types for the weak dependency tags, so it never worked. Add a test to ensure it works and stays that way.

Fixes: #624

@pmatilai pmatilai force-pushed the weakqual-pr branch 3 times, most recently from 2507bba to 078ccae Compare March 12, 2024 12:30
@pmatilai pmatilai added RFE bug and removed RFE labels Mar 12, 2024
@pmatilai pmatilai marked this pull request as draft March 12, 2024 12:48
@pmatilai
Copy link
Member Author

Converting to draft for now, there's something weird going on with CI

Commit ddbf30c neglected to update the
preamble table types for the weak dependency tags, so it never worked.
Add a test to ensure it works and stays that way.

Test depends on 078ccae

Fixes: rpm-software-management#624
@pmatilai pmatilai marked this pull request as ready for review March 12, 2024 13:05
@pmatilai
Copy link
Member Author

Uh, so that was just some disturbances in the cosmic order it seems.

@ffesti ffesti merged commit 0644ba5 into rpm-software-management:master Mar 13, 2024
1 check passed
@pmatilai pmatilai added the packaging Package building, SPEC files, etc. label Mar 14, 2024
@pmatilai pmatilai deleted the weakqual-pr branch March 14, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug packaging Package building, SPEC files, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weak dependencies do not allow qualifiers
2 participants