Split the internal OpenPGP parser to a separate repository #2986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Push the build option into the rpmpgp_legacy directory so it doesn't show up at all unless the directory is present, and rename it to WITH_LEGACY_OPENPGP to better reflect the status: it's hardly internal if it lives in a separate repo, and it's something you should not use going forward. Add a terse README to the rpmpgp_legacy directory as the initial to-be repo description to explain the status and intentionally vague build instructions: if you don't know then you really should not. Also add a separate COPYING file there: the parser originates from rpmio/ so it falls under rpm's dual license, just simplify the text that makes no sense in the new context.
Now that we have an alternative to building without Rust, it's time to say bye to this old thing. We will not support the parser but preserve minimal hooks in cmake to allow building with it, at least for a transition period: https://github.com/rpm-software-management/rpmpgp_legacy Fixes: rpm-software-management#2414
pmatilai
added
cleanup
crypto
|
And RIP 馃 |
|
Million thanks @nwalfield and @teythoon for making this possible! Every software engineer knows some code is more expensive to maintain than others, but I wonder: how do you measure it? In kilograms? 馃槃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally. Chomp it goes 馃獡
See commit messages for details.
Fixes #2414